-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added verification and scoring functionality. Created usePassport hook. #1
base: scaffold-eth-gitcoin-passport
Are you sure you want to change the base?
Added verification and scoring functionality. Created usePassport hook. #1
Conversation
@austintgriffith whats the best way to figure out if this is a good PR from a scaffold.eth/build guild perspective? @kevinrolsen is the GPG interested in revivewing this at all or merging it upstream into their docs as a client? |
README.md
Outdated
|
||
# 🏄♂️ Quick Start | ||
## Hosted Demo | ||
This app is hosted in GitHub Pages and can be accessed [here](https://lucianhymer.github.io/Scaffold-eth-gitcoin-passport). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 🔥
This looks great. Awesome work 🚀 🚀 🚀 . From @owocki posts in the passport-builder channel it is evident this will be a sandbox/starting point for other passport dapps. We want to make sure the code is accessible and fairly easy for someone to pick up. I like the comments you added and the updates to the readme. A further update that I think is necessary would be to update the .sample.env with all the environment variables used for the update. |
Thanks for checking this over @farque65! I've updated that .sample.env file |
@owocki @lucianHymer I created a new branch from these changes and pushed it to the main branch #2 The changes have been merged. I created a |
I've added verification and scoring functionality and done general cleanup including creating a usePassport hook to centralize passport logic in the dapp.
These changes were made with the intention that they make it easier for a developer to create a dapp using Gitcoin Passport with this as their starting point.
This was done for Gitcoin Issue #29193.